Open
Conversation
GarethCabournDavies
requested review from
Copilot and
maxtrevor
and removed request for
Copilot
titodalcanton
added
low latency
dependencies
Contributor
titodalcanton
left a comment
titodalcanton
left a comment
There was a problem hiding this comment.
Just a quick look with some comments. Also, please rebase on master.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the project’s only remaining usage of gwpy by updating the live script pycbc_live_collated_dq_trigger_rates to use PyCBC-native frame reading and DQ/segment utilities, enabling removal of gwpy from companion.txt (per #5257).
Changes:
- Drop the
gwpydependency fromcompanion.txt. - Replace
gwpyDQ querying andTimeSeriesDictreading withpycbc.dq.query_flagandpycbc.frame.frame.read_frame. - Add a helper to convert boolean time-sampled data into
igwn_segments.segmentlistand use segment operations to compute flagged livetime.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
companion.txt |
Removes gwpy from companion dependencies. |
bin/live/pycbc_live_collated_dq_trigger_rates |
Replaces gwpy timeseries/DQFlag logic with PyCBC frame reads and igwn segment arithmetic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxtrevor
reviewed
Mar 5, 2026
Contributor
maxtrevor
left a comment
maxtrevor
left a comment
There was a problem hiding this comment.
Looks good to me, except possibly for Tito's question about catching and reraising an error
GarethCabournDavies
force-pushed
the
remove_gwpy
branch
from
057118a to
4e436c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
pycbc_live_collated_dq_trigger_ratesto use pycbc-native stuff rather than gwpy. This means that we can remove gwpy from companion.txtCloses #5257
Standard information about the request
This is a change to use already-included code rather than external processes
This change affects the live search
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: remove a companion dependency
Testing performed
I would like to run an example of this with code before/after, but trying to find an example with still-existing files is not obvious!